[test] Demonstrate per-layer module resolution via package.json imports#93701
Draft
unstubbable wants to merge 1 commit intocanaryfrom
Draft
[test] Demonstrate per-layer module resolution via package.json imports#93701unstubbable wants to merge 1 commit intocanaryfrom
unstubbable wants to merge 1 commit intocanaryfrom
Conversation
Adds an e2e fixture under `test/e2e/app-dir/universal-module/` that shows a single import identifier (`#universal`) resolving to different files depending on the React layer of the importer, via a `react-server` subpath-import condition: - React Server layer: `./app/_universal/server.ts` (async, inline `'use cache'`) - elsewhere: `./app/_universal/client.ts` (`'use client'`, async) The page renders four reads — server component direct, server component via an indirect shared re-export, client component direct, client component via the same shared re-export — confirming the resolution is driven by the importer's layer, including for universal helper modules that get duplicated across layers.
Contributor
Tests PassedCommit: e598613 |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: e598613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an e2e fixture under
test/e2e/app-dir/universal-module/that shows a single import identifier (#universal) resolving to different files depending on the React layer of the importer, via areact-serversubpath-import condition:./app/_universal/server.ts(async, inline'use cache')./app/_universal/client.ts('use client', async)The page renders four reads — server component direct, server component via an indirect shared re-export, client component direct, client component via the same shared re-export — confirming the resolution is driven by the importer's layer, including for universal helper modules that get duplicated across layers.