TURBOPACK: expose node ecmascript chunk types and accessors#93722
Open
yuzheng14 wants to merge 1 commit intovercel:canaryfrom
Open
TURBOPACK: expose node ecmascript chunk types and accessors#93722yuzheng14 wants to merge 1 commit intovercel:canaryfrom
yuzheng14 wants to merge 1 commit intovercel:canaryfrom
Conversation
Promote `EcmascriptBuildNodeChunk`, `EcmascriptBuildNodeEntryChunk`, and `EcmascriptBuildNodeRuntimeChunk` from `pub(crate)` to `pub`, and re-export them from `turbopack_nodejs`, mirroring the browser-side visibility. Add public accessors needed for downstream consumers (e.g. webpack-compatible stats generation): - `EcmascriptBuildNodeChunk::chunk()` — exposes the inner `Chunk` for chunk_items - `EcmascriptBuildNodeEntryChunk::chunks_data()` / `evaluatable_assets()` / `module_graph()` / `chunking_context()` — mirror `EcmascriptBrowserEvaluateChunk` No behavior changes inside turbopack-nodejs itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote
EcmascriptBuildNodeChunk,EcmascriptBuildNodeEntryChunk, andEcmascriptBuildNodeRuntimeChunkfrompub(crate)topub, and re-export them fromturbopack_nodejs, mirroring the browser-side visibility.Add public accessors needed for downstream consumers (e.g. webpack-compatible stats generation):
EcmascriptBuildNodeChunk::chunk()— exposes the innerChunkfor chunk_itemsEcmascriptBuildNodeEntryChunk::chunks_data()/evaluatable_assets()/module_graph()/chunking_context()— mirrorEcmascriptBrowserEvaluateChunkNo behavior changes inside turbopack-nodejs itself.