switch our test benchmark runs to release-with-assertions#94538
Merged
Conversation
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 2518afb |
Contributor
Tests PassedCommit: 2518afb |
lukesandberg
force-pushed
the
run_test_bench_without_lto
branch
from
e8b410b to
a9756f7
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
bgw
reviewed
Jun 8, 2026
lukesandberg
force-pushed
the
run_test_bench_without_lto
branch
2 times, most recently
from
68efe24 to
dd6a1c2
Compare
lukesandberg
commented
Jun 16, 2026
bgw
approved these changes
Jun 16, 2026
Under release-with-assertions (debug-assertions on), the dev server tripped debug_assert_not_in_top_level_task by reading task outputs eventually consistently from top-level run_once tasks, panicking worker threads and hanging the turbopack-cli benchmark. - Make IssueReporter::report_issues a plain async method (not a turbo-task) that takes pre-collected PlainIssues; collect them in a new collect_issues operation read strongly consistently in handle_issues. Mark ConsoleUi::new root so the reporter can be resolved strongly consistently. - Apply content-source side effects via a new apply_side_effects_operation read strongly consistently instead of awaiting each apply() at the top level. - Compute the initial HMR version in initial_version_operation and read the update-stream content strongly consistently in UpdateStream::new.
lukesandberg
force-pushed
the
run_test_bench_without_lto
branch
from
dd6a1c2 to
87ff08c
Compare
Replace the implicit `--bench` argv detection (IS_TEST_MODE) with an explicit LARGE_DB env var. The benches now scale down by default for both `cargo bench` and `cargo test --benches`; set LARGE_DB to run the full (large) sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ci when testing our benchmarks use our test profile
release-with-assertionsThis avoids an expensive
ltostep and ensures that our tests run with debug asserts.I noticed that our workflow for 'test cargo benches' was very slow and a lot of that time was the build presumably due to lto overheads across so many benchmark binaries.
Compare:
Of course doing this revealed a few things
And finally, that the persistence tests are just extremely slow in test mode due to their initialization overhead (populating >1GB dbs), so that harness is rewritten to remove some variants and also to reduce max sizes in test mode