Skip to content

[turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_params to ChunkGroupResult#94661

Open
sampoder wants to merge 1 commit into
sp/turbopack/registration_code_methodfrom
sp/turbopack/registration-code-on-chunk-group
Open

[turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_params to ChunkGroupResult#94661
sampoder wants to merge 1 commit into
sp/turbopack/registration_code_methodfrom
sp/turbopack/registration-code-on-chunk-group

Conversation

@sampoder

@sampoder sampoder commented Jun 10, 2026

Copy link
Copy Markdown
Member

We used to generate the runtime file for each ChunkGroupResult in evaluated_chunk_group(), I've added registration_code to store the small route-specific bit of the runtime so in a future PR it can be inlined.

Whether or not the inline-able code is generated is based on the inline_chunk_group_bootstrap which is still false in all cases at the moment but will be turned to true in #94666.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Stats skipped

Commit: 2c0d2e4
View workflow run

@sampoder sampoder changed the title sp/turbopack/registration code on chunk group [turbopack] Add inline_registration to BrowserChunkingContext and registration_code to ChunkGroupResult Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 2c0d2e4 | About building and testing Next.js

pnpm test-dev test/development/app-dir/hmr-intercept-routes/hmr-intercept-routes.test.ts (job)

  • hmr-intercept-routes > should update intercept routes via HMR (DD)
Expand output

● hmr-intercept-routes › should update intercept routes via HMR

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#default-intercept') to be visible

  560 |
  561 |     return this.startChain(async () => {
> 562 |       const el = await page.waitForSelector(selector, {
      |                             ^
  563 |         timeout,
  564 |         state,
  565 |       })

  at waitForSelector (lib/browsers/playwright.ts:562:29)
  at Playwright._chain (lib/browsers/playwright.ts:692:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:673:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:561:17)
  at Object.waitForElementByCss (development/app-dir/hmr-intercept-routes/hmr-intercept-routes.test.ts:38:21)

pnpm test-dev test/development/app-dir/watch-distdir-deletion/index.test.ts (job)

  • app-dir watch-distdir-deletion > should restart the server when distDir is deleted (DD)
Expand output

● app-dir watch-distdir-deletion › should restart the server when distDir is deleted

ENOTEMPTY: directory not empty, rmdir '/tmp/next-install-8587a83f282d35e08776cbe54e44ce3185edc57496ab787f280617bfb6c6b1d0/.next/dev'

Other failing CI jobs

@sampoder sampoder force-pushed the sp/turbopack/registration_code_method branch from 6b49c90 to 58512bf Compare June 10, 2026 18:29
@sampoder sampoder force-pushed the sp/turbopack/registration-code-on-chunk-group branch 2 times, most recently from 75fabe3 to 29ccc8e Compare June 10, 2026 18:48
@sampoder sampoder force-pushed the sp/turbopack/registration_code_method branch from 58512bf to 0ce9422 Compare June 10, 2026 18:48
@sampoder sampoder changed the title [turbopack] Add inline_registration to BrowserChunkingContext and registration_code to ChunkGroupResult [turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_code to ChunkGroupResult Jun 10, 2026
@sampoder sampoder marked this pull request as ready for review June 10, 2026 18:55
@sampoder sampoder requested review from bgw and lukesandberg and removed request for bgw June 10, 2026 18:59
@sampoder sampoder force-pushed the sp/turbopack/registration_code_method branch from 0ce9422 to da06b98 Compare June 10, 2026 21:40
@sampoder sampoder force-pushed the sp/turbopack/registration-code-on-chunk-group branch from 29ccc8e to 396c30a Compare June 10, 2026 21:40
@sampoder sampoder requested a review from bgw June 10, 2026 21:40
@sampoder sampoder changed the title [turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_code to ChunkGroupResult [turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_params to ChunkGroupResult Jun 10, 2026
…text` and `chunk_group_bootstrap_params` to `ChunkGroupResult`
@sampoder sampoder force-pushed the sp/turbopack/registration-code-on-chunk-group branch from 396c30a to 2c0d2e4 Compare June 10, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant