[turbopack] Add inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_params to ChunkGroupResult#94661
Open
sampoder wants to merge 1 commit into
Conversation
Contributor
Stats skippedCommit: 2c0d2e4 |
inline_registration to BrowserChunkingContext and registration_code to ChunkGroupResult
Contributor
Failing test suitesCommit: 2c0d2e4 | About building and testing Next.js
Expand output● hmr-intercept-routes › should update intercept routes via HMR
Expand output● app-dir watch-distdir-deletion › should restart the server when distDir is deleted Other failing CI jobs |
6b49c90 to
58512bf
Compare
75fabe3 to
29ccc8e
Compare
58512bf to
0ce9422
Compare
inline_registration to BrowserChunkingContext and registration_code to ChunkGroupResultinline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_code to ChunkGroupResult
0ce9422 to
da06b98
Compare
29ccc8e to
396c30a
Compare
inline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_code to ChunkGroupResultinline_chunk_group_bootstrap to BrowserChunkingContext and chunk_group_bootstrap_params to ChunkGroupResult
…text` and `chunk_group_bootstrap_params` to `ChunkGroupResult`
396c30a to
2c0d2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to generate the runtime file for each
ChunkGroupResultinevaluated_chunk_group(), I've addedregistration_codeto store the small route-specific bit of the runtime so in a future PR it can be inlined.Whether or not the inline-able code is generated is based on the
inline_chunk_group_bootstrapwhich is still false in all cases at the moment but will be turned to true in #94666.