fix(sdk): lazy-load auth path dependency - #283
Open
bryan-hunter wants to merge 1 commit into
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xdg-app-pathswhen Sandbox accesses local CLI authProduction context
The observed Vade production failure originated from the separate
@vercel/cli-configdependency path:path.parse(undefined)@vercel/cli-configSandbox was not the dependency responsible for that deployment failure. However, Sandbox independently depends on
xdg-app-paths@5.1.0and eagerly imports it from its auth module, exposing the same import-time failure mode. This PR applies the equivalent fix here as a defensive measure in case Sandbox is evaluated in the same kind of entrypoint-less server build runtime.Root cause
xdg-app-paths@5.1.0constructs its default export at module load and callspath.parse(require.main?.filename ?? process.argv[0]). A server build worker with neither value can therefore fail while importing Sandbox, before Sandbox auth is used.Fix
Resolve
xdg-app-pathsinsidegetGlobalPathConfig()so the import-time side effect runs only when local CLI auth is accessed.