fix(#4247): use useTransition to track mutation isMutating#4248
Open
SukkaW wants to merge 2 commits into
Open
Conversation
6b2ecdf to
33a39a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
action prop), any state update inside the transition (a.k.a. thetriggeris called within a transition (e.g. React'striggerfunction) will be deferred/delayed until the transition finishes, which means the async function is resolved/rejected.However, we don't want the
isMutatingupdate (false -> true -> false) to be deferred/delayed, otherwise the UI won't be able to reflect the loading state.One way to do this is to use
useTransition. In React 19,useTransition'sisPendingcan be used to track async transition resolved/rejected state. AndisPendingwould be an urgent update that won't be deferred/delayed.React 18's
useTransitiondoesn't support async function tracking. In React 16 and 17, there is nouseTransitionat all. A polyfill is introduced.Alternative
Technically, we can use
flushSyncto force an urgent update, but it can be dangerous and may cause undefined behavior when invoked within a transition. It may even cause a Suspense boundary fallback to reappear, which is not ideal. Also,flushSyncis areact-domAPI.Caveat
We lose the re-render optimization for
isMutating. Now the component will always re-render whenisPending/isMutaingchanges no matter the component actually readisMutaingfield or not.