fix: read swr devtools on demand#4257
Open
SukkaW wants to merge 3 commits into
Open
Conversation
|
The goat 🐐 |
SukkaW
force-pushed
the
fix-swr-devtools-inject
branch
from
6929992 to
71b0812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes: koba04/swr-devtools#133
Due to Chrome extension limitation, the SWR DevTools may not inject
window.__SWR_DEVTOOLS_USE__fast enough (koba04/swr-devtools#133 (comment)), while SWR currently tries to readwindow.__SWR_DEVTOOLS_USE__at the module level, which is way too early. By the time the SWR DevTools extension finally injectswindow.__SWR_DEVTOOLS_USE__, SWR already setsenableDevtoolstofalse.Here are the PR changes:
window.__SWR_DEVTOOLS_USE__on demand instead of pre-populatedwindow.__SWR_DEVTOOLS_SETUP__to the SWR DevTools extension, in case the SWR devtools load too slow and miss the opportunity to grab theReactinstance.cc @koba04 @shuding @promer94 @huozhi