Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of resource config on vercel_project resource. #286

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix usage of resource config on vercel_project resource. #286

merged 1 commit into from
Mar 19, 2025

Conversation

dglsparsons
Copy link
Collaborator

  • properly support null or unknown values for this field.
  • remove false defaults of null for the fields.
  • Fix validation allowing 0 or 901 as timeout values.
  • Remove a lot of unnecessary code to suppress diffs.
  • Allow setting resourceConfig on project creation.

@dglsparsons
Fix usage of resource config on vercel_project resource.
549762c 
- properly support null or unknown values for this field.
- remove false defaults of `null` for the fields.
- Fix validation allowing `0` or `901` as timeout values.
- Remove a lot of unnecessary code to suppress diffs.
- Allow setting resourceConfig on project creation.
@dglsparsons dglsparsons requested a review from QuiiBz March 19, 2025 12:59
@dglsparsons dglsparsons enabled auto-merge (squash) March 19, 2025 13:00
@dglsparsons dglsparsons merged commit b3fd40e into main Mar 19, 2025
5 checks passed
@dglsparsons dglsparsons deleted the dgls/fix-resource-config branch March 19, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigandrews craigandrews craigandrews approved these changes

@QuiiBz QuiiBz Awaiting requested review from QuiiBz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dglsparsons @craigandrews