Deprecate project public_source field - #541
Closed
dglsparsons wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the
vercel_project.public_sourceand project data sourcepublic_sourceattributes now that Vercel no longer supports project-level public source/log visibility.This also stops sending
publicSourcein create project payloads. For the resource, the deprecated Terraform value is preserved from config/state when reading so existing configurations do not hit perpetual diffs or inconsistent-result errors when the API omits the field.Root cause
publicSourcewas removed from the Projects API after the source/log visibility backfill. Older provider behavior still sent the field and expected it back, sopublic_source = truecould apply successfully and then read back as null.Validation
env GOCACHE=/private/tmp/tpv-go-build-cache-public-source go test ./vercel -run 'TestConvertResponseToProject|TestProject|TestDataSourceProject'env GOCACHE=/private/tmp/tpv-go-build-cache-public-source go test ./client -run '^$'A broader
go test ./client ./vercelwas attempted before the rebase, but this sandbox cannot bindhttptestports and cannot access the local GPG agent for acceptance-style tests that create signed git commits.