chore: upgrade to Rust 1.83.0#9652
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ognevny is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
| // Child::wait is run after writing `s` into stdin | ||
| #[allow(clippy::zombie_processes)] |
There was a problem hiding this comment.
This is actually a valid lint. If we fail to write to the child's stdin then we will end up with a zombie processes as we exit before calling wait
There was a problem hiding this comment.
refactor is needed to fix this lint...
chris-olszewski
changed the title
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
2 similar comments
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
### Description As discovered in #9652 (comment) We could create a zombie process if writing to the clipboard program failed as we handled the write failure without `wait`ing the clipboard process. ### Testing Instructions We no longer get a lint warning when removing `allow(clippy::zombie_process)`
3 participants
Description
needless_lifetimesexcluding turborepo-lib as code generated by tonic-build are also lint so there is 50+ warnings :(zombie_processonce as it's buggyTesting Instructions