Skip to content

fix(hooks): extend session cleanup timeout #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ketpatil77 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

fix(hooks): extend session cleanup timeout #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hooks/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"hooks": [
{
"type": "command",
"command": "node \"${CLAUDE_PLUGIN_ROOT}/hooks/session-end-cleanup.mjs\""
"command": "node \"${CLAUDE_PLUGIN_ROOT}/hooks/session-end-cleanup.mjs\"",
"timeout": 15
}
]
}
Expand Down
16 changes: 16 additions & 0 deletions tests/session-end-cleanup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,22 @@ describe("session-end-cleanup", () => {
});

describe("hooks.json wiring", () => {
test("gives session cleanup enough time during contended teardown", () => {
const config = JSON.parse(readFileSync(HOOKS_CONFIG_PATH, "utf-8")) as {
hooks?: {
SessionEnd?: Array<{
hooks?: Array<{ type?: string; command?: string; timeout?: number }>;
}>;
};
};

const cleanupHook = config.hooks?.SessionEnd
?.flatMap((entry) => entry.hooks ?? [])
.find((hook) => hook.command?.includes("session-end-cleanup.mjs"));

expect(cleanupHook?.timeout).toBe(15);
});

test("does not register the Agent pretooluse observer hook", () => {
const config = JSON.parse(readFileSync(HOOKS_CONFIG_PATH, "utf-8")) as {
hooks?: {
Expand Down