chore(deps): bump lodash to 4.18.1 - #216
Merged
Merged
Conversation
Takes the lodash half of dependabot PR #214 (security fixes GHSA-f23m-r3pf-42rh and GHSA-r5fr-rjxr-66jc / CVE-2026-4800) while keeping webpack at 5.76.0, since the webpack 5.104 bump changes bundle codegen and breaks all output-comparison test fixtures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: styfle <styfle@users.noreply.github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #214, taking only the lodash half of the grouped update.
Why #214's CI fails
#214 bumps two lockfile-only deps: webpack 5.76.0 → 5.104.1 and lodash 4.17.21 → 4.18.1 (both resolve within existing
package.jsonranges; webpack is a devDependency, lodash is transitive).The test suite compares the entire webpack-generated bundle byte-for-byte against checked-in fixtures (
test/unit/*/output.js, plus expected chunk filenames intest/project-chunking). webpack 5.104 changes codegen — method-shorthand module rendering in__webpack_modules__, different module ids, changed IIFE wrapping — so 71 of 85 tests fail on every OS, e.g.:The loader itself still relocates assets correctly under webpack 5.104; the mismatches are formatting/ids. But accepting the bump would mean regenerating ~71 fixtures twice (
output.js+output-coverage.js) plus the project-chunking expectations — a huge, hard-to-review diff.This PR (path of least change)
_.unset/_.omitprototype pollution, GHSA-r5fr-rjxr-66jc / CVE-2026-4800_.templatecode injection). lodash is dev-tooling-only here and appears in no fixture output.Verification
yarn testandyarn test-coverageboth pass 85/85 locally on Node 22 with webpack 5.76.0 + lodash 4.18.1 (reproduced #214's 71 failures locally first, then confirmed green after dropping the webpack bump).🤖 Generated with Claude Code