Skip to content

chore(deps): bump lodash to 4.18.1 - #216

Merged
styfle merged 1 commit into
mainfrom
fix-ci-failure-in-asset-relocator-pr
Aug 7, 2026
Merged

chore(deps): bump lodash to 4.18.1#216
styfle merged 1 commit into
mainfrom
fix-ci-failure-in-asset-relocator-pr

Conversation

@styfle

@styfle styfle commented Aug 7, 2026

Copy link
Copy Markdown
Member

Supersedes #214, taking only the lodash half of the grouped update.

Why #214's CI fails

#214 bumps two lockfile-only deps: webpack 5.76.0 → 5.104.1 and lodash 4.17.21 → 4.18.1 (both resolve within existing package.json ranges; webpack is a devDependency, lodash is transitive).

The test suite compares the entire webpack-generated bundle byte-for-byte against checked-in fixtures (test/unit/*/output.js, plus expected chunk filenames in test/project-chunking). webpack 5.104 changes codegen — method-shorthand module rendering in __webpack_modules__, different module ids, changed IIFE wrapping — so 71 of 85 tests fail on every OS, e.g.:

-/***/ 147:
-/***/ ((module) => {
+/***/ 896
+(module) {

The loader itself still relocates assets correctly under webpack 5.104; the mismatches are formatting/ids. But accepting the bump would mean regenerating ~71 fixtures twice (output.js + output-coverage.js) plus the project-chunking expectations — a huge, hard-to-review diff.

This PR (path of least change)

Verification

yarn test and yarn test-coverage both pass 85/85 locally on Node 22 with webpack 5.76.0 + lodash 4.18.1 (reproduced #214's 71 failures locally first, then confirmed green after dropping the webpack bump).

🤖 Generated with Claude Code

Takes the lodash half of dependabot PR #214 (security fixes
GHSA-f23m-r3pf-42rh and GHSA-r5fr-rjxr-66jc / CVE-2026-4800) while
keeping webpack at 5.76.0, since the webpack 5.104 bump changes
bundle codegen and breaks all output-comparison test fixtures.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Co-Authored-By: styfle <styfle@users.noreply.github.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​lodash@​4.17.21 ⏵ 4.18.181 +1100 +1987 +182100

View full report

@styfle
styfle merged commit a0b7ae7 into main Aug 7, 2026
8 checks passed
@styfle
styfle deleted the fix-ci-failure-in-asset-relocator-pr branch August 7, 2026 19:45
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant