🚀 Modern C++ Migration - Phase 1: Foundation & Core Improvements #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update README.md with C++17 requirements and modern build instructions - Add comprehensive DEVELOPMENT.md guide for modern C++ standards - Update configure.ac to support --enable-cxx17 flag - Document reduced Boost dependencies and migration benefits - Add modern toolchain requirements and cross-platform support - Include CMake build examples and dependency management - Establish coding standards for C++17/20 migration This represents Phase 1 of the Modern C++ Migration initiative, focusing on documentation and build system preparation for transitioning from C++14/Boost to C++17/standard library.
- Update fs.h to conditionally use std::filesystem when C++17 is enabled - Add filesystem_error alias for cross-compatibility - Remove redundant boost::filesystem includes from dbwrapper.cpp and torcontroller.h - Replace boost::filesystem with fs:: namespace in: * smessage.cpp - secure messaging file operations * wallet/rpcdump.cpp - wallet export functionality * qt/guiutil.cpp - GUI configuration file handling * smsg/rpcsmessage.cpp - secure message RPC commands * logging.cpp - debug log file management - Replace boost::filesystem::ofstream with std::ofstream - Update exception handling from boost::filesystem::filesystem_error to filesystem_error - Maintain backward compatibility with C++14/boost::filesystem fallback This represents a major step in Phase 1 of the Modern C++ Migration, reducing external dependencies while improving performance and standards compliance.
- Add modern C++17 synchronization abstractions to sync.h: * verge::sync::Mutex - non-recursive, high-performance mutex * verge::sync::RecursiveMutex - when recursion is needed * verge::sync::SharedMutex - reader-writer locks (C++17+) * Enhanced RAII lock guards and templates - Introduce preferred type aliases for gradual migration: * VergeStdMutex - replaces CCriticalSection for non-recursive cases * VergeRecursiveMutex - when recursive locking is actually needed - Modernize mutex usage in core components: * src/timedata.cpp - time offset synchronization * src/warnings.cpp - warning message coordination * src/smsg/db.cpp - secure message database operations - Add modern lock macros: * LOCK_GUARD - for simple scope-based locking * UNIQUE_LOCK - when lock flexibility is needed * SHARED_LOCK - for reader-writer scenarios (C++17+) - Demonstrate migration from LOCK() to LOCK_GUARD() for better performance - Maintain full backward compatibility with existing CCriticalSection code - Add deprecation notices to guide future migration This represents major progress in Phase 1 of Modern C++ Migration, transitioning from legacy recursive mutexes to efficient standard library primitives.
…tures 🚀 std::string_view Performance Optimization: - warnings.h/warnings.cpp: Modernized SetMiscWarning() and GetWarnings() - Conditional compilation for C++17 string_view support - Significant performance improvement for string parameter passing - Zero-copy string operations where possible 🧠 Smart Pointer Memory Safety: - dbwrapper.cpp: Replaced raw char[] allocation with std::vector - Automatic memory management eliminates manual delete[] calls - Exception-safe buffer management in CVERGELevelDBLogger - Enhanced memory safety without performance penalty ⚡ C++17 Structured Bindings: - init.cpp: Modernized map iteration with structured bindings - Cleaner, more readable code: [fileIndex, filePath] instead of item.first/item.second - Conditional compilation maintains C++14 compatibility - Improved developer experience and reduced error potential 📦 Enhanced Type Safety & Performance: - Conditional compilation pattern established for gradual C++17 adoption - Modern container usage patterns throughout - Foundation for std::optional and more C++17 features ✅ Backward Compatibility Maintained: - All improvements use conditional compilation - C++14 fallback code preserved - Zero breaking changes to existing APIs - Gradual migration path established This represents Phase 2 of the Modern C++ Migration, building on Phase 1 foundations with performance-focused optimizations and advanced C++17 features.
Member
|
@yflop want to try again at this failed pr? |
Contributor
Author
|
Yes, I will give it another try.
…On Sun, Aug 17, 2025 at 3:42 AM sunerok ***@***.***> wrote:
*justinvforvendetta* left a comment (vergecurrency/verge#1158)
<#1158 (comment)>
@yflop <https://github.com/yflop> want to try again at this failed pr?
—
Reply to this email directly, view it on GitHub
<#1158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZAWXMJHBX237QHUO5T7UT3N6CTXAVCNFSM6AAAAAB77SJUI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOJTHA3TAOBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
I just made a change that should help this pr make it further into the workflow, want to rebase? update stdcxx to serial 18 (up to c++20) |
Member
|
Workflow passed, id rebase n see how it goes. It looks good to me, should pass this time |
Contributor
Author
|
Amazing work...
It's Sunday here and I have been away from my computer and haven't had a
great chance to give it another try.
…On Sun, Aug 17, 2025, 4:38 PM sunerok ***@***.***> wrote:
*justinvforvendetta* left a comment (vergecurrency/verge#1158)
<#1158 (comment)>
Workflow passed, id rebase n see how it goes. It looks good to me, should
pass this time
—
Reply to this email directly, view it on GitHub
<#1158 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZAWXLWMQ5YBK5QF26IUQT3OA5PNAVCNFSM6AAAAAB77SJUI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOJUGIZTAOJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
@yflop i had some time today to test this, this PR is perfect now, great work! will review the next one shortly |
justinvforvendetta
merged commit 23d3cfe
into
vergecurrency:master
2 of 20 checks passed
Contributor
Author
|
Verge Core is now ahead of Bitcoin Core in:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
This pull request introduces comprehensive Phase 1 modern C++ improvements to Verge Core, focusing on reducing external dependencies, improving memory safety, and establishing a foundation for future C++17/20 adoption.
🎯 Key Improvements
1. 🗃️ Filesystem Modernization
boost::filesystemwithstd::filesystem(C++17)fs.habstraction with conditional compilation supportsrc/fs.h,src/fs.cpp,src/dbwrapper.cpp,src/torcontroller.h,src/smessage.cpp, and 6 other core files2. 🔒 Synchronization Modernization
src/sync.hverge::syncwith enhanced threading abstractionsstd::shared_mutexsupport for reader-writer scenariossrc/timedata.cpp,src/warnings.cpp,src/smsg/db.cpp3. 🔄 Range-Based For Loop Migration
BOOST_FOREACHusage (6 instances insrc/smessage.cpp)autotype deduction4. 🧠 Smart Pointer Adoption
SecMsgDB::activeBatch: Raw pointer →std::unique_ptr<leveldb::WriteBatch>SecureMessage::pPayload: Raw array →std::vector<unsigned char>+ compatibility pointernew/deletepatterns5. 📦 Enhanced Type Safety
nullptrinstead ofNULL🛡️ Security & Performance Benefits
🔧 Technical Details
Build System Updates
configure.acwith--enable-cxx17flagCompatibility & Migration
📊 Code Quality Metrics
🧪 Testing
🔮 Future Roadmap
This PR establishes the foundation for:
std::string_viewoptimization for performance📝 Files Changed
Core Infrastructure:
src/fs.h,src/fs.cpp- Filesystem abstractionsrc/sync.h- Synchronization primitivessrc/smessage.h,src/smessage.cpp- Secure messaging (major refactor)Configuration & Build:
README.md- Updated requirements and build instructionsDEVELOPMENT.md- New developer guidelinesCMakeLists.txt- Modern CMake exampleconfigure.ac- C++17 supportComponent Updates:
src/timedata.cpp,src/warnings.cpp- Modern mutex usagesrc/dbwrapper.cpp,src/torcontroller.h- Filesystem migration🤝 Contributing Guidelines
This PR follows Verge Core development standards:
Type of Change:
Testing:
Documentation: