Support external wallets and social logins #461
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ethers as a dependency in both did-document and types packages. - Updated IDIDDocument interface and DIDDocument class to replace privateKey with Signer in addContext and signProof methods. - Refactored related methods to utilize Signer for signing operations.
- Updated StorageLink methods to use Signer instead of private key for signing operations. - Added ethers as a dependency in storage-link package.
- Cleaned up whitespace and formatting in client.ts to enhance readability. - Removed unnecessary comments and ensured consistent formatting in test files. - Updated test files to maintain consistency with the latest code structure.
…tions - Updated VdaDid and BlockchainApi classes to replace privateKey with Signer for signing operations. - Modified related methods to ensure consistent use of Signer across the codebase. - Adjusted test files to reflect changes in the API and maintain compatibility with the new signing approach.
- Replaced instances of the deprecated Wallet class with VeridaDidWallet in create-account and get-account-info commands. - Updated DIDClient to utilize VeridaDidWallet for managing DID identifiers and signing operations. - Introduced utility functions for building Verida DID identifiers and added a new VeridaDidWallet class for enhanced wallet management. - Adjusted tests to reflect changes in the wallet implementation and ensure compatibility with the new structure.
- Introduced SignerAccount class to manage signing operations using ethers' Signer. - Updated AutoAccount and ContextAccount to extend SignerAccount, streamlining authentication and context management. - Refactored storage linking and context consent message handling to utilize the new structure. - Added utility functions for context consent message generation. - Updated tests to ensure compatibility with the new account management approach and the integration of ethers.
- Introduced WalletAccount class to manage wallet operations and integrate with VeridaDidWallet. - Updated AutoAccount to extend WalletAccount, enhancing authentication and signing capabilities. - Refactored related configurations and methods to utilize the new WalletAccount structure. - Added tests for WalletAccount to ensure functionality and compatibility with existing features.
|
On hold for now, see #460 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.