add isqrt #25
Open
add isqrt #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You could update the readme too to say that isqrt is done. Also maybe the readme should be more clear about what it's talking about - it was kind of a snapshot at the time of submission for a grant (hence it fixes particular HOL and Verifereum commits), but maybe we want to now make it living again (can be in this PR or separately). |
| | BlockHash | ||
| | Env env_item | ||
| | Acc account_item | ||
| | Isqrt |
Contributor
There was a problem hiding this comment.
i think it would be cleaner for builtins to go inside of a separate datatype (maybe even further broken down by builtin class, e.g. BUILTIN_Math, BUILTIN_Chain, BUILTIN_Env, etc)
Member
There was a problem hiding this comment.
This is already the built-in datatype right? Maybe we can refactor it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i need to add more tests, particularly about the consistent rounding charles mentioned. also i think we need to merge json ast first?