feat: prove revert_to_assert (take 2) #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds HOL4 proof skeleton for verifying the revert-to-assert optimization pass. Includes definitions, helper lemmas, and main correctness theorems (with cheats for filling in later). Files: - revertAssertDefsScript.sml: Pattern predicates, state_equiv_except - revertAssertPropsScript.sml: Instruction behavior lemmas (36 cheats) - revertAssertCorrectScript.sml: Main theorems (4 cheats, 2 proved) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
xrchz
approved these changes
Dec 28, 2025
Member
xrchz
left a comment
xrchz
left a comment
There was a problem hiding this comment.
This is great!
Some comments for next steps:
- All the lemmas (A-D, or maybe just A-C) could be put in a general theory of properties about the semantics, they aren't super specific to this pass.
- I suggest the next PR either just defines the compiler pass, or just proves those lemmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.