Skip to content

[RegTests] Commented Out 3-Bit Adders in the VTR Nightly Tests #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ueqri
Copy link
Contributor

@ueqri ueqri commented Oct 25, 2024

Commented out the tiny circuit (3-bit adder in vtr_reg_nightly_test1/ arithmetic_tasks/figure_8/adder_003bits.v and the same test for ODIN) in both config and golden_results files.

It was a hotfix for PR #2785, which forgot to make these changes.

All failures, except for vtr_reg_nightly_test7/titan_other_run_flat as mentioned in Issue #2786, have been fixed now.

Commented out the tiny circuit (3-bit adder in `vtr_reg_nightly_test1/
arithmetic_tasks/figure_8/adder_003bits.v` and the same test for ODIN)
in both config and golden_results files.

It was a hotfix for PR verilog-to-routing#2785, which forgot to make these changes.

All failures, except for `vtr_reg_nightly_test7/titan_other_run_flat` as
mentioned in Issue verilog-to-routing#2786, have been fixed now.
@ueqri
Copy link
Contributor Author

ueqri commented Oct 25, 2024

@vaughnbetz Hi, Vaughn. I believe this PR is ready to merge. I just deleted a few lines (for the deprecated 3-bit adder) in the golden_results, and commented out this adder in the ODIN nightly test (which I forgot to do).

@vaughnbetz
Copy link
Contributor

Thanks @ueqri !
@soheilshahrouz : one failure in odd/even routing unit tests. It looks like an incremental vs. brute-force NoC cost calculations mismatch. Maybe a flaw in the incremental code (or a difference anyway)?

2024-10-25T21:14:57.7216984Z �[0m�[0;37m/home/runner/work/vtr-verilog-to-routing/vtr-verilog-to-routing/vpr/test/test_odd_even_routing.cpp:228: �[0m�[1;31mFAILED:
2024-10-25T21:14:57.7217163Z �[0mdue to unexpected exception with message:
2024-10-25T21:14:57.7217555Z basic_string::_M_construct null not valid
2024-10-25T21:14:57.7217573Z
2024-10-25T21:14:57.7218085Z Error 1: noc_aggregate_bandwidth_cost_check: 1.51241e+07 and noc_aggregate_bandwidth_cost: 1.54266e+07 differ in check_noc_placement_costs.
2024-10-25T21:14:57.7218441Z Error 2: noc_latency_cost_check: 64624 and noc_latency_cost: 63331.5 differ in check_noc_placement_costs.
2024-10-25T21:14:57.7218863Z Error 3: noc_latency_overrun_cost_check: 21119.3 and noc_latency_overrun_cost: 21541.7 differ in check_noc_placement_costs.
2024-10-25T21:14:57.7219242Z Error 4: noc_congestion_cost_check: 348155 and noc_congestion_cost: 355118 differ in check_noc_placement_costs.

@vaughnbetz vaughnbetz merged commit f520c17 into verilog-to-routing:master Oct 26, 2024
36 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants