Unused Packer Options Cleanup #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
yenjames
force-pushed
the
jy-pack-option-cleanup
branch
from
de69bcb to
46964db
Compare
vaughnbetz
approved these changes
Apr 28, 2025
vpr/src/base/vpr_types.h
Outdated
| * circuit's resource requirements) | ||
| * @param timing_update_type | ||
| * Controls how timing analysis updates are performed. (Default: auto) | ||
| * @param use_attraction_groups |
There was a problem hiding this comment.
I think this option is unused. Please check that, and if it is unused, delete it.
… referred to as timing_gain_weight and connection_gain_weight, used as a weight parameter during timing and connection driven clustering respectively. Removed global_clocks, use_attraction_groups, pack_num_moves, pack_move_type from packer.
yenjames
force-pushed
the
jy-pack-option-cleanup
branch
from
6179397 to
f762360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing and updating old options in the packer types class.
Description
alpha_clustering,beta_clusteringin front-end option parsing, butalpha,betawithin packer. Standardized name totiming_gain_weightandconnection_gain weightfor front-end option, packer, and documentation.Related Issue
See issue #2964.
Motivation and Context
How Has This Been Tested?
Running VPR manual flow, strong CI tests.
Types of changes
Checklist: