[APPack] Updated Max Candidate Distance Interface #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
AlexandreSinger
force-pushed
the
feature-appack-max-dist-cli
branch
from
3fe979c to
a77545a
Compare
AlexandreSinger
force-pushed
the
feature-appack-max-dist-cli
branch
from
a77545a to
1a5b841
Compare
amin1377
requested changes
May 5, 2025
|
@amin1377 Regarding where the default values came from, I did perform a parameter sweep around 1 month ago when I was tuning the flow for a paper. However, a lot has changed in the last month which will have caused these values to change. I plan to do another sweep later. This interface will make this sweep significantly easier. |
The max candidate distance is used by APPack to decide which molecules to ignore when packing, based on their distance from the cluster being formed. Cleaned up the interface of this by pre-computing the max candidate distance of all logical blocks ahead of time and reading from these pre-computed values during packing. Added a command-line option to allow the user to override some or all of these max distance thresholds. By default, VPR will select values based on the type of logical block and the primitives it contains. Fixed issue with APPack creating too many IO blocks for some circuits due to the max candidate distance thresholds for IO blocks being too low. More tuning should be done on these values once the mass legalizer has been cleaned up a bit more.
AlexandreSinger
force-pushed
the
feature-appack-max-dist-cli
branch
from
1a5b841 to
4079c04
Compare
|
@amin1377 Thank you so much for the review. I agreed with your comment and updated how the class is initialized. Please let me know if you have any further comments. |
amin1377
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max candidate distance is used by APPack to decide which molecules to ignore when packing, based on their distance from the cluster being formed.
Cleaned up the interface of this by pre-computing the max candidate distance of all logical blocks ahead of time and reading from these pre-computed values during packing.
Added a command-line option to allow the user to override some or all of these max distance thresholds. By default, VPR will select values based on the type of logical block and the primitives it contains.
Fixed issue with APPack creating too many IO blocks for some circuits due to the max candidate distance thresholds for IO blocks being too low.
More tuning should be done on these values once the mass legalizer has been cleaned up a bit more.
Resolves #3020