Skip to content

RR graph generation directory #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 20, 2025
Merged

RR graph generation directory #3050

merged 13 commits into from
May 20, 2025
+801 −772

Conversation

soheilshahrouz
Copy link
Contributor

Moved all source/header files related to RR graph generation under route/ directory to rr_graph_generation subdirectory.
Moves all functions related to initializing RRSpationLookup to newly created rr_node_indices.h/.cpp files
Added doxygen comments for function in rr_node_indices.h/.cpp

@soheilshahrouz soheilshahrouz requested a review from vaughnbetz May 16, 2025 21:58
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels May 16, 2025
@github-actions github-actions bot added the libarchfpga Library for handling FPGA Architecture descriptions label May 19, 2025
vaughnbetz
vaughnbetz reviewed May 19, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup ... thanks.
I suggest a few more comments, on things you didn't write but would be useful to document, if you are able to figure out the functions / structs I noted.

vaughnbetz
vaughnbetz approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soheilshahrouz soheilshahrouz merged commit d89ea99 into master May 20, 2025
96 of 98 checks passed
@soheilshahrouz soheilshahrouz deleted the temp_rr_graph_gen_dir branch May 20, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soheilshahrouz @vaughnbetz