-
Notifications
You must be signed in to change notification settings - Fork 415
[Infra] The Great VPR Pragma PR #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Infra] The Great VPR Pragma PR #3077
Conversation
@soheilshahrouz Sorry for the larger PR. This PR moves all include files to use pragma once. Please review when you have a moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex.
I left a few comments aboud inlucding header files from catch2
. I think because catch2
is a submodule in this project, we should include its header files with double double quotation marks.
@soheilshahrouz Thank you so much for your review. I would agree that header files that are included in the project should use double quotations, however library headers should use brackets. In this case we should be using brackets since VTR actually includes Catch2 as system headers: vtr-verilog-to-routing/libs/EXTERNAL/CMakeLists.txt Lines 162 to 168 in 607788b
I am ok with being vetoed on this, I am not married to it, but I think using angle brackets is proper in this case. What do you think? |
VPR is moving to a style that uses "#pragma once" instead of header gaurds. These are less error prone and may be slightly more performant. Converted all of the header gaurds in VPR into pragma once's. Also moved all pragma onces to the top of all header files to maintain a consistent style. It is a good idea to have them as the very first line in all header files. While going through all header files, cleaned up any extra header includes which were including things they did not need.
@soheilshahrouz Ah! I see, I just looked at the code and what you are saying is that it already used double quotation marks and I added angle brackets justs on the ones I added. I understand why thats not good. I turned them into double quotation marks so this does not block the PR; however, we should eventually revisit this topic. Not urgent at all though. |
6b8b6bc
to
d2fa91d
Compare
VPR is moving to a style that uses "#pragma once" instead of header gaurds. These are less error prone and may be slightly more performant.
Converted all of the header gaurds in VPR into pragma once's.
Also moved all pragma onces to the top of all header files to maintain a consistent style. It is a good idea to have them as the very first line in all header files.
While going through all header files, cleaned up any extra header includes which were including things they did not need.