Skip to content

Propagate docker group ID into container #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: rogerwangcs/dood
Choose a base branch
from
Draft

Propagate docker group ID into container #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
447f99b
doodscratch
npc-g Feb 3, 2025
646e6ba
forward port
npc-g Feb 4, 2025
f8bc88b
revert ports
npc-g Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/workbench-jupyter-docker/.devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"service": "app",
"shutdownAction": "none",
"workspaceFolder": "/workspace",
"initializeCommand": "DOCKER_GID=`getent group docker | cut -d: -f3` && echo \"DOCKER_GID=${DOCKER_GID}\" > .env",
"postCreateCommand": "./startupscript/post-startup.sh jupyter /home/jupyter ${templateOption:cloud} ${templateOption:login} && ./startupscript/setup-docker.sh",
// re-mount bucket files on container start up
"postStartCommand": [
Expand Down
2 changes: 1 addition & 1 deletion src/workbench-jupyter-docker/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ services:
app:
container_name: "application-server"
image: "us-central1-docker.pkg.dev/verily-workbench-public/apps/workbench-jupyter:latest"
user: "jupyter"
user: "jupyter:${DOCKER_GID}"
restart: always
volumes:
- .:/workspace:cached
Expand Down
Loading