Update FHOW notebooks due to org-linked groups #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update First Hour on Workbench notebooks to be compatible with org-linked Workbench groups and to explain about the differences between legacy groups and org-linked groups.
Update Working with Groups notebook to address org-linked groups, in addition to legacy groups. Add utility method for flat-listing members of nested groups.
emmarogge
force-pushed
the
emmarogge/update_fhvwb
branch
from
c1e240e to
b6aa3d9
Compare
mspector
approved these changes
May 13, 2025
| html = f"""<table style='margin: 0 auto,text-align: left'>""" | ||
| html += "<th>ROLE</th>" | ||
| html += "<th>USER_EMAILS</th>" | ||
| html += "<tr>" |
There was a problem hiding this comment.
whenever I have to do something like this (construct html from strings) I wonder if there's a better way...
not asking for a change -- I think this is perfectly fine in small doses. just musing that it might be worth some thought someday.
| """ List VWB groups in which user is a member in HTML table form. | ||
| """ | ||
| html = f"""<table style='margin: 0 auto,text-align: left'>""" | ||
| json_data = json.loads(json_string) | ||
| # html += "<th>ORG_ID</th>" |
There was a problem hiding this comment.
is this communicating intent of some kind, or a stray comment? there are a few similar commented-out html strings below
| description: str = "" | ||
| bound_int_widget: widgets.BoundedIntText = None | ||
|
|
||
| def __post_init__(self): |
There was a problem hiding this comment.
neato. I didn't know about this function
| " Email: <GROUP_NAME>@verily.com\n", | ||
| " # Members: 1\n", | ||
| " Current user's policies: ADMIN\n", | ||
| " Organization : <ORG_ID>\n", |
There was a problem hiding this comment.
I admit I don't have a great mental model for what's happening here, but if those commented HTML strings will affect what should be written here, this is a reminder to update here accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update First Hour on Workbench notebooks to be compatible with org-linked Workbench groups and to explain about the differences between legacy groups and org-linked groups.