Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new installation script, install_veomni.sh, to set up the environment for the VeOmni RL Engine. The script is a good starting point, but I've identified a few critical issues related to its robustness and reliability. My feedback focuses on adding proper error handling to prevent partial installations, ensuring the script is idempotent so it can be run multiple times without manual intervention, and improving consistency in package management. Addressing these points will make the script more stable and user-friendly.
|
Hi @A1waysBeenHere and @ji-huazhong. I’m planning to start extending the VeOmni engine from #4072 to RL training tomorrow and work on it over the next few days. Posting here to coordinate in case this overlaps with anything you’re already working on. |
Work in progress to extend VeOmni engine to RL training