[tool] refactor: Unify the profiler tools in one place#5573
Open
zhink wants to merge 2 commits intoverl-project:mainfrom
Open
[tool] refactor: Unify the profiler tools in one place#5573zhink wants to merge 2 commits intoverl-project:mainfrom
zhink wants to merge 2 commits intoverl-project:mainfrom
Conversation
zhink
requested review from
ArronHZG,
ISEEKYAN,
vermouth1992 and
wuxibin89
as code owners
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a PROFILER_TOOL_NAMES constant to unify the handling of profiler tool names. The hardcoded lists of profiler names in env_worker.py, engine_workers.py, fsdp_workers.py, and megatron_workers.py have been replaced with this new constant. The constant is defined in verl/utils/profiler/config.py and exported through verl/utils/profiler/__init__.py. The changes appear correct and serve to centralize the configuration.
zhink
changed the title
Author
|
@ArronHZG please review its |
Collaborator
|
Please run |
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As title