[megatron] fix: avoid mindspeed rope and attention synchronization#5574
Draft
Shangwei-Li wants to merge 1 commit intoverl-project:mainfrom
Draft
[megatron] fix: avoid mindspeed rope and attention synchronization#5574Shangwei-Li wants to merge 1 commit intoverl-project:mainfrom
Shangwei-Li wants to merge 1 commit intoverl-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a synchronization issue with the Mindspeed backend by moving cu_seqlens tensors to the CPU. The change is functionally correct and resolves the described problem. I've included a minor refactoring suggestion to improve code clarity and avoid redundant operations.
Comment on lines
401
to
409
| packed_seq_params = PackedSeqParams( | ||
| qkv_format="thd", | ||
| cu_seqlens_q=cu_seqlens_padded, | ||
| cu_seqlens_q=cu_seqlens_padded.cpu(), | ||
| max_seqlen_q=max_seqlen_in_batch, | ||
| cu_seqlens_kv=cu_seqlens_padded, | ||
| cu_seqlens_kv=cu_seqlens_padded.cpu(), | ||
| max_seqlen_kv=max_seqlen_in_batch, | ||
| cu_seqlens_q_padded=cu_seqlens_padded, | ||
| cu_seqlens_kv_padded=cu_seqlens_padded, | ||
| cu_seqlens_q_padded=cu_seqlens_padded.cpu(), | ||
| cu_seqlens_kv_padded=cu_seqlens_padded.cpu(), | ||
| ) |
Contributor
There was a problem hiding this comment.
To improve readability and avoid redundant calls, it's better to move cu_seqlens_padded to the CPU once and store it in a variable. This variable can then be used for all the cu_seqlens parameters.
cu_seqlens_padded_cpu = cu_seqlens_padded.cpu()
packed_seq_params = PackedSeqParams(
qkv_format="thd",
cu_seqlens_q=cu_seqlens_padded_cpu,
max_seqlen_q=max_seqlen_in_batch,
cu_seqlens_kv=cu_seqlens_padded_cpu,
max_seqlen_kv=max_seqlen_in_batch,
cu_seqlens_q_padded=cu_seqlens_padded_cpu,
cu_seqlens_kv_padded=cu_seqlens_padded_cpu,
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By default
cu_seqlensis generated on device, and causing synchronization during rope and attention when using Mindspeed backend. This pr fix it by movecu_seqlensto cpu before forward.Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,fully_async,one_step_off,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
before:


after:
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.