Skip to content

[megatron] fix: avoid mindspeed rope and attention synchronization#5574

Draft
Shangwei-Li wants to merge 1 commit intoverl-project:mainfrom
Shangwei-Li:cu_seqlens_fix
Draft

[megatron] fix: avoid mindspeed rope and attention synchronization#5574
Shangwei-Li wants to merge 1 commit intoverl-project:mainfrom
Shangwei-Li:cu_seqlens_fix

Conversation

@Shangwei-Li
Copy link
Contributor

@Shangwei-Li Shangwei-Li commented Mar 12, 2026

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

By default cu_seqlens is generated on device, and causing synchronization during rope and attention when using Mindspeed backend. This pr fix it by move cu_seqlens to cpu before forward.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, fully_async, one_step_off
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

before:
image
after:
image

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a synchronization issue with the Mindspeed backend by moving cu_seqlens tensors to the CPU. The change is functionally correct and resolves the described problem. I've included a minor refactoring suggestion to improve code clarity and avoid redundant operations.

Comment on lines 401 to 409
packed_seq_params = PackedSeqParams(
qkv_format="thd",
cu_seqlens_q=cu_seqlens_padded,
cu_seqlens_q=cu_seqlens_padded.cpu(),
max_seqlen_q=max_seqlen_in_batch,
cu_seqlens_kv=cu_seqlens_padded,
cu_seqlens_kv=cu_seqlens_padded.cpu(),
max_seqlen_kv=max_seqlen_in_batch,
cu_seqlens_q_padded=cu_seqlens_padded,
cu_seqlens_kv_padded=cu_seqlens_padded,
cu_seqlens_q_padded=cu_seqlens_padded.cpu(),
cu_seqlens_kv_padded=cu_seqlens_padded.cpu(),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To improve readability and avoid redundant calls, it's better to move cu_seqlens_padded to the CPU once and store it in a variable. This variable can then be used for all the cu_seqlens parameters.

    cu_seqlens_padded_cpu = cu_seqlens_padded.cpu()
    packed_seq_params = PackedSeqParams(
        qkv_format="thd",
        cu_seqlens_q=cu_seqlens_padded_cpu,
        max_seqlen_q=max_seqlen_in_batch,
        cu_seqlens_kv=cu_seqlens_padded_cpu,
        max_seqlen_kv=max_seqlen_in_batch,
        cu_seqlens_q_padded=cu_seqlens_padded_cpu,
        cu_seqlens_kv_padded=cu_seqlens_padded_cpu,
    )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant