Skip to content

Xa2 instructions#4

Closed
AlexEdimensionz wants to merge 13 commits intovermut:masterfrom
AlexEdimensionz:XA2-instructions
Closed

Xa2 instructions#4
AlexEdimensionz wants to merge 13 commits intovermut:masterfrom
AlexEdimensionz:XA2-instructions

Conversation

@AlexEdimensionz
Copy link

  • IP tables command can't be executed if rsync already running. Reversed the order
  • The revert process is different (easier) for t he XA2

@rfvermut
Copy link
Collaborator

I'm reluctant of merging XA2 specific code here.

  • I cannot test is right now
  • It's already a bit of the mess with --env LXC and if's inside code

What I propose:

  • This repo stays as pure Android 4.4 patch and I will update README to reflect it
  • @yeoldegrove fork will focus on new Android 8.1 LXC and remove everything non-LXC
  • We build and publish docker images into DockerHub. Because I feel git submodules and internal make introduce unnecessary complications for users, and my goal was to make it as simple as ever possible.

@yeoldegrove WDYT?

@AlexEdimensionz
Copy link
Author

My pull request doesn't remove the existing instructions. i added a section at the bottom for XA2

@yeoldegrove
Copy link

yeoldegrove commented Apr 26, 2019

@AlexEdimensionz You can create a PR against https://github.com/yeoldegrove/sailfish-signature-spoofing-lxc against the master branch. We can merge this there.

@rfvermut I like your idea of splitting it up... Makes it more easy to maintain.

@rfvermut
Copy link
Collaborator

@yeoldegrove what would be the good telltale of LXC environment? So I can add it to script like

if [[ -f /etc/LXC ]]; then
  echo "Seems like you are using tool for older Android version. Please use yeoldegrove/sailfish-signature-spoofing-lxc"
  echo "https://github.com/yeoldegrove/sailfish-signature-spoofing-lxc"
  exit 1
fi

@yeoldegrove
Copy link

@rfvermut
test -f /var/lib/lxc/aliendalvik/config should be enough

By the way... Funny this is going so fast and we both already have everything up and running ;)

@yeoldegrove
Copy link

@AlexEdimensionz I opened a new PR for you here: yeoldegrove#7

@rfvermut
Copy link
Collaborator

Nothing can stop SFOS.

I added simple validation: f35aa89#diff-1b0c2b516b83393edb7200ad5ff12181R6

@rfvermut rfvermut closed this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants