[17.0][FIX] sale_invoice_policy: invoice policy#16
Merged
Drsmartinkus merged 1 commit into17.0-versadafrom Feb 11, 2026
Merged
Conversation
Fix sale order invoice policy to work regardless of required setting. Before this fix, the sale order invoice_policy field only affected invoicing calculations when invoice_policy_required was set to True. When invoice_policy_required was False, the invoice policy was ignored, and the system fell back to the default product level invoice policies. This was problematic because users could set an invoice policy on sale orders, but it would not work. Now the sale order invoice policy works correctly even when the field is not marked as required, allowing optional but functional invoice policies.
Author
|
Task here. |
Drsmartinkus
changed the title
maciej-wichowski
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sale order invoice policy to work regardless of required setting.
Before this fix, the sale order invoice_policy field only affected invoicing calculations when invoice_policy_required was set to True. When invoice_policy_required was False, the invoice policy was ignored, and the system fell back to the default product level invoice policies.
This was problematic because users could set an invoice policy on sale orders, but it would not work. Now the sale order invoice policy works correctly even when the field is not marked as required, allowing optional but functional invoice policies.