Skip to content

Add missing "active" property to RtpEncodingParameters type #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Add missing "active" property to RtpEncodingParameters type #175

wants to merge 1 commit into from

Conversation

@t-mullen
Copy link
Contributor

@t-mullen t-mullen commented Jul 15, 2021 •
edited
Loading

Description

Adds the missing "active" property to RtpEncodingParameters type which is otherwise a superset of RTCRtpEncodingParameters.

Usecase

Calling Producer::setRtpEncodingParameters to activate/deactivate encodings.

@ibc
Copy link
Member

ibc commented Aug 31, 2025

Actually the public API of mediasoup client doesn't allow setting active field of encoding on purpose. This is not just about exposing active in TS types. It's that literally the active field is ignored if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-mullen @ibc