Skip to content

Support for zero capacity nodes#143

Open
ikalachy wants to merge 11 commits into
vert-x3:masterfrom
ikalachy:fix/zero-capacity-nodes-5-x
Open

Support for zero capacity nodes#143
ikalachy wants to merge 11 commits into
vert-x3:masterfrom
ikalachy:fix/zero-capacity-nodes-5-x

Conversation

@ikalachy

Copy link
Copy Markdown

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@tsegismont tsegismont left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @ikalachy

Regarding tests I can't see where the Vert.x nodes are declared as zero capacity nodes. Can you clarify?

Also, I think it would be best to implement integration tests for zero capacity nodes like we have for vertx-hazelcast, see https://github.com/vert-x3/vertx-hazelcast/tree/master/vertx-hazelcast/src/test/java/io/vertx/spi/cluster/hazelcast/it/litemembers

Comment thread vertx-infinispan/pom.xml
Comment on lines +275 to +294
<!-- <plugin>-->
<!-- <artifactId>maven-compiler-plugin</artifactId>-->
<!-- <executions>-->
<!-- <execution>-->
<!-- <id>default-compile1</id>-->
<!-- <goals>-->
<!-- <goal>compile</goal>-->
<!-- </goals>-->
<!-- <configuration>-->
<!-- <annotationProcessorPaths>-->
<!-- <annotationProcessorPath >-->
<!-- <groupId>org.infinispan.protostream</groupId>-->
<!-- <artifactId>protostream-processor</artifactId>-->
<!-- <version>5.0.13.Final</version>-->
<!-- </annotationProcessorPath>-->
<!-- </annotationProcessorPaths>-->
<!-- </configuration>-->
<!-- </execution>-->
<!-- </executions>-->
<!-- </plugin>-->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- <plugin>-->
<!-- <artifactId>maven-compiler-plugin</artifactId>-->
<!-- <executions>-->
<!-- <execution>-->
<!-- <id>default-compile1</id>-->
<!-- <goals>-->
<!-- <goal>compile</goal>-->
<!-- </goals>-->
<!-- <configuration>-->
<!-- <annotationProcessorPaths>-->
<!-- <annotationProcessorPath >-->
<!-- <groupId>org.infinispan.protostream</groupId>-->
<!-- <artifactId>protostream-processor</artifactId>-->
<!-- <version>5.0.13.Final</version>-->
<!-- </annotationProcessorPath>-->
<!-- </annotationProcessorPaths>-->
<!-- </configuration>-->
<!-- </execution>-->
<!-- </executions>-->
<!-- </plugin>-->

@tsegismont tsegismont changed the title Fix/zero capacity nodes 5 x Support for zero capacity nodes Apr 24, 2025
ikalachy and others added 5 commits April 25, 2025 12:59
…/impl/SubsCacheHelper.java

Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
…/impl/SubsCacheHelper.java

Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
…/impl/SubsCacheHelper.java

Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
…/impl/SubsCacheHelper.java

Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants