You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The key locator was previously and internal implementation detail. It was not correct according to redis. It now follows redis and still it's an internal implementation detail.
Which use case are you trying to do that would require this to be public?
Ok, thanks for the explanation about the key locator. But how about the other arguments, the command, arity, readOnly and others...?
Before the commit 8d45692 in #328, I implemented something like that for the RedisBloom commands, use the function Command.create, only the bloom commands so I did not make a pull request here.
Although I don't need it now, because the commands are build-in supported now. But as we know there are many modules and one can also create new modules. Will the other arguments need to be public when we create new command with vertx-redis-client?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Expose more Command create arguments to let user create custom command.
Or further, do you think we should a this? Please:
In this case, maybe we should change package
io.vertx.redis.client.impl.keystoio.vertx.redis.client.keys.