feat(web-validation): replace deprecated SchemaParser with new Schema…#2445
Draft
feat(web-validation): replace deprecated SchemaParser with new Schema…#2445
Conversation
tsegismont
reviewed
Jul 6, 2023
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @pk-work
Have you been able to get to the bottom of the failures?
vertx-web-validation/src/main/java/io/vertx/ext/web/validation/ValidationHandler.java
Outdated
Show resolved
Hide resolved
vertx-web-validation/src/main/java/io/vertx/ext/web/validation/ValidationHandler.java
Show resolved
Hide resolved
...b-validation/src/main/java/io/vertx/ext/web/validation/builder/ValidationHandlerBuilder.java
Show resolved
Hide resolved
Comment on lines
+48
to
+49
| // Not the best way to retrieve Vert. instance I guess. We could also try to get it from SchemaRouter | ||
| // via schemaParser.getSchemaRouter(), but the vertx field is private. |
Member
There was a problem hiding this comment.
That is an acceptable limitation, I think. Anyway it's only temporary.
When this is merged, keep in mind to document the limitation in the deprecations and breaking changes doc.
…Repository Signed-off-by: Pascal Krause <pascal.krause@sap.com>
pk-work
force-pushed
the
4_4_web_validation_replace_deprecated
branch
from
8f75544 to
8b15f85
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Repository
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines