Fixed docs of vertx-web - #2598
Open
ShivamPansuriya wants to merge 2 commits into
Open
Conversation
Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251
Contributor
|
@pmlopes can you double check this ? I am not sure |
Author
Member
tsegismont
reviewed
Apr 15, 2024
tsegismont
left a comment
Member
There was a problem hiding this comment.
Thanks for pointing this out. I think it would be best to split example3 into two smaller examples. And then, in the doc, we can reference them separately so it's clearer the first sentence refers to the first example, and the second sentence to the second example.
Signed-off-by: ShivamPansuriya <pansuriyashivam@gmail.com>
Author
thanks for the help. it worked for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251
Motivation:
There was a contradictory statement in vertx-web docs at #routing-by-exact-path.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines