Skip to content

Fixed docs of vertx-web - #2598

Open
ShivamPansuriya wants to merge 2 commits into
vert-x3:masterfrom
ShivamPansuriya:master
Open

Fixed docs of vertx-web#2598
ShivamPansuriya wants to merge 2 commits into
vert-x3:masterfrom
ShivamPansuriya:master

Conversation

@ShivamPansuriya

Copy link
Copy Markdown

Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251

Motivation:
There was a contradictory statement in vertx-web docs at #routing-by-exact-path.

Conformance:

Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

Changes in vertx-web/src/main/asciidoc/index.adoc @line-250,251
@vietj

vietj commented Apr 15, 2024

Copy link
Copy Markdown
Contributor

@pmlopes can you double check this ? I am not sure

@ShivamPansuriya

Copy link
Copy Markdown
Author

What is required for me to get necessary legal agreements? @vietj @pmlopes

@tsegismont

Copy link
Copy Markdown
Member

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

@tsegismont tsegismont left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I think it would be best to split example3 into two smaller examples. And then, in the doc, we can reference them separately so it's clearer the first sentence refers to the first example, and the second sentence to the second example.

Signed-off-by: ShivamPansuriya <pansuriyashivam@gmail.com>
@ShivamPansuriya

Copy link
Copy Markdown
Author

What is required for me to get necessary legal agreements? @vietj @pmlopes

You must sign the Eclipse Contributor Agreement and invoke git commit with -s (signoff), assuming git config user.email and author.email are set to the email address provided when signing the contributor agreement.

thanks for the help. it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants