Skip to content

Add catch all error handler#2633

Merged
tsegismont merged 1 commit intovert-x3:masterfrom
code-brazier:issues/2632
Jan 6, 2026
Merged

Add catch all error handler#2633
tsegismont merged 1 commit intovert-x3:masterfrom
code-brazier:issues/2632

Conversation

@code-brazier
Copy link
Copy Markdown
Contributor

Adding the feature described in #2632

@vietj
Copy link
Copy Markdown
Contributor

vietj commented Jul 16, 2024

@code-brazier can you instead name it "uncaughtErrorHandler"

@vietj vietj added this to the 5.0.0 milestone Jul 16, 2024
@tsegismont
Copy link
Copy Markdown
Member

@code-brazier thank you for proposing this.

Can you explain how this defers from:

router.route().failureHandler(myUncaughtFailureHandler)

@code-brazier
Copy link
Copy Markdown
Contributor Author

@tsegismont Router.errorHandler() and the proposed Router.uncaughtErrorHandler() are at a slightly higher level than Route.failureHandler()

Please correct this if it's not completely right, but basically the Router error handlers should catch any problems that occur before a Route handler (context or failure) is called, or if a Route handler throws an exception

Can I please ask if you know how I can get help creating an account with the eclipse foundation? I've emailed them to see what's happening with the account creation but haven't heard back from them. Thanks!

@tsegismont
Copy link
Copy Markdown
Member

Can I please ask if you know how I can get help creating an account with the eclipse foundation? I've emailed them to see what's happening with the account creation but haven't heard back from them. Thanks!

Let me check with them who can help you.

@code-brazier
Copy link
Copy Markdown
Contributor Author

I wasn't able to approve the email address I originally pushed with, so I have replaced my original commits with one from my approved email address. Is this ok or should I create a new branch?

@tsegismont
Copy link
Copy Markdown
Member

It's fine

@code-brazier
Copy link
Copy Markdown
Contributor Author

I've reapplied my commit and run the tests locally for vertx-web
[INFO] Tests run: 1035, Failures: 0, Errors: 0, Skipped: 0

Could I please request approval for the CI workflow?

@vietj vietj modified the milestones: 5.0.0, 5.1.0 May 14, 2025
Copy link
Copy Markdown
Member

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @code-brazier , this looks good to me

@tsegismont tsegismont merged commit adee0db into vert-x3:master Jan 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants