Ensuring that cookie sessions are reusable across nodes#2746
Merged
Conversation
vietj
reviewed
May 22, 2025
Member
Author
|
@vietj please pick the right version for this issue.
If we want to be strict, then this is a 5.1.0, however, due to the security upgrade and bug fix, it may go on a 5.0.x release either. |
Contributor
|
I think it is fine to be in 5.0.x, please notice that now the master branch is 5.1.0-SNAPSHOT so it needs backport to the new 5.0 branch |
Member
|
@pmlopes it seems there are formatting issues in tests. About the deprecated method: I assume an existing cookie couldn't be processed after the upgrade, correct? In this case, it might be worth adding a note in the breaking changes page after your merge the PR. Thanks for this contrib! |
Member
Author
Contributor
|
@pmlopes I only need it for 5.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix #2745
This PR changes the underlying algorithm for security reasons and fixes the test that IVs are stored in the cookie so they can be decripted on other nodes, making the statement that sessions can survive a server crash correct.
Regarding the algorithm:
With this update we move away from
AES/CBCto the recommended (by NIST)AES/GCM