Subrouter failure handler is ignored#2779
Merged
tsegismont merged 3 commits intovert-x3:masterfrom Feb 16, 2026
Merged
Conversation
Contributor
Author
|
this pull but ok: ci test for 5.x in win11 cost < but another fail ci test for 5.x-stable in win11 cost >
|
We can use existing testRequest methods Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
changed the title
tsegismont
approved these changes
Feb 16, 2026
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @takeseem
I made some changes so that we reuse existing methods in WebTestBase
tsegismont
added a commit
to tsegismont/vertx-web
that referenced
this pull request
Feb 16, 2026
* fix vert-x3#2772 Subrouter failure handler is ignored * fix(test): do junit assert in vert.x and add timeout * Revert changes in WebTestBase We can use existing testRequest methods Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com> Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-web
that referenced
this pull request
Feb 16, 2026
* fix vert-x3#2772 Subrouter failure handler is ignored * fix(test): do junit assert in vert.x and add timeout * Revert changes in WebTestBase We can use existing testRequest methods Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com> Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Feb 16, 2026
* fix #2772 Subrouter failure handler is ignored * fix(test): do junit assert in vert.x and add timeout * Revert changes in WebTestBase We can use existing testRequest methods --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com> Co-authored-by: takeseem <takeseem@users.noreply.github.com>
tsegismont
added a commit
to tsegismont/vertx-web
that referenced
this pull request
Feb 16, 2026
* fix vert-x3#2772 Subrouter failure handler is ignored * fix(test): do junit assert in vert.x and add timeout * Revert changes in WebTestBase We can use existing testRequest methods Signed-off-by: Thomas Segismont <tsegismont@gmail.com> --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com> Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Feb 16, 2026
* fix #2772 Subrouter failure handler is ignored * fix(test): do junit assert in vert.x and add timeout * Revert changes in WebTestBase We can use existing testRequest methods --------- Signed-off-by: Thomas Segismont <tsegismont@gmail.com> Co-authored-by: takeseem <takeseem@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2772
Subrouter failure handler is ignored