feat: Adding support for SSE on the WebClient#2794
Merged
tsegismont merged 1 commit intovert-x3:masterfrom Nov 6, 2025
Merged
Conversation
ehsavoie
force-pushed
the
sse_client
branch
from
a38c5e7 to
458fc76
Compare
vietj
requested changes
Sep 24, 2025
Contributor
vietj
left a comment
vietj
left a comment
There was a problem hiding this comment.
we need for now
- at least 1 integration test with WebClient
- SseBodyCodec and tests should be in vertx-web-common package instead where BodyCodec is
ehsavoie
force-pushed
the
sse_client
branch
2 times, most recently
from
4efdb3b to
fdd4b43
Compare
tsegismont
reviewed
Sep 26, 2025
ehsavoie
force-pushed
the
sse_client
branch
from
fdd4b43 to
2087406
Compare
Contributor
Author
|
@tsegismont maybe I could make the SseEvent toString to acutally create a 'valid'SSE string with the new lines |
ehsavoie
force-pushed
the
sse_client
branch
2 times, most recently
from
b232c03 to
fddd3ac
Compare
vietj
reviewed
Oct 2, 2025
vietj
reviewed
Oct 2, 2025
vietj
reviewed
Oct 2, 2025
vietj
requested changes
Oct 11, 2025
4 tasks
tsegismont
reviewed
Oct 16, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @ehsavoie ! This looks great already. I think we need to make the new objects Vert.x API objects (annotated with @VertxGen or @DataObject).
Otherwise, they won't be available in generated bindings.
That might require a bit of refactoring, you can inspire from other codecs, like BodyCodec.
ehsavoie
force-pushed
the
sse_client
branch
6 times, most recently
from
9274840 to
5164652
Compare
tsegismont
reviewed
Oct 17, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you for the updates @ehsavoie !
tsegismont
reviewed
Oct 20, 2025
Member
tsegismont
reviewed
Oct 23, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Any reason for not moving the test from web-common to web-client?
Contributor
Author
|
@tsegismont I've move the test |
Member
|
@ehsavoie can you please rebase the PR ? Thank you |
Contributor
Author
|
@tsegismont rebased |
tsegismont
reviewed
Nov 6, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @ehsavoie , there's just one modification that is no longer required. Can you please revert it? Then we're ready to merge
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Contributor
Author
|
@tsegismont everything should be ok now |
ehsavoie
added a commit
to ehsavoie/vertx-web
that referenced
this pull request
Nov 14, 2025
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
added a commit
to ehsavoie/vertx-web
that referenced
this pull request
Nov 14, 2025
Bckporting PR (vert-x3#2794) to 5.0.x Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
ehsavoie
added a commit
to ehsavoie/vertx-web
that referenced
this pull request
Nov 14, 2025
Bckporting PR (vert-x3#2794) to 5.0.x Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
tsegismont
pushed a commit
that referenced
this pull request
Nov 17, 2025
Bckporting PR (#2794) to 5.0.x Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I needed to be able to process SSE events on the client side.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines