Fix request absolute URI handling#2833
Merged
tsegismont merged 2 commits intovert-x3:masterfrom Jan 23, 2026
Merged
Conversation
tsegismont
reviewed
Dec 15, 2025
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
There seems to be a compilation problem. Can you take a look?
Contributor
tmonney
force-pushed
the
fix-2830-absolute-uri
branch
from
a800296 to
97039b2
Compare
Contributor
Author
|
@vietj @tsegismont sorry, I was quite busy before the holidays, then busy during the holidays, and of course even more busy after the holidays... |
Member
|
We have issues in Vert.x Web build right now because of the recent updates in Vert.x core for HTTP/3 I'll come back to this when they are resolved. Thanks for the heads-up |
Member
|
Could you please rebase the PR ? |
When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes vert-x3#2830
tmonney
force-pushed
the
fix-2830-absolute-uri
branch
from
78f9172 to
586338e
Compare
tsegismont
reviewed
Jan 21, 2026
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thanks for the updates @tmonney
tsegismont
added a commit
to tsegismont/vertx-web
that referenced
this pull request
Jan 23, 2026
* Fix request absolute URI handling When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes vert-x3#2830 * Update vertx-web/src/main/java/io/vertx/ext/web/impl/ForwardedParser.java --------- Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
to tsegismont/vertx-web
that referenced
this pull request
Jan 23, 2026
* Fix request absolute URI handling When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes vert-x3#2830 * Update vertx-web/src/main/java/io/vertx/ext/web/impl/ForwardedParser.java --------- Co-authored-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jan 23, 2026
* Fix request absolute URI handling When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes #2830 * Update vertx-web/src/main/java/io/vertx/ext/web/impl/ForwardedParser.java --------- Co-authored-by: Thierry Monney <thierry.monney@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Jan 23, 2026
* Fix request absolute URI handling When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request: ``` GET http://www.example.com:1234/path HTTP/1.1 Host: www.example.com:1234 ``` The result of HttpServerRequest.absoluteURI() would then be: `http://www.example.com:1234www.example.com:1234/path` With this change, when the request target is absolute, only the path (and query) are added to the Host value: `http://www.example.com:1234/path` Fixes #2830 * Update vertx-web/src/main/java/io/vertx/ext/web/impl/ForwardedParser.java --------- Co-authored-by: Thierry Monney <thierry.monney@gmail.com>
Contributor
Author
|
@tsegismont thanks for finishing the work, and sorry I was not more responsive! |
Member
|
No problem, thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a request uses an absolute request target with scheme and host parts, the current absoluteURI() method simply concatenates the Host header value and the request target URI. For example, with the following request:
The result of HttpServerRequest.absoluteURI() would then be:
http://www.example.com:1234www.example.com:1234/pathWith this change, when the request target is absolute, only the path (and query) are added to the Host value:
http://www.example.com:1234/pathFixes #2830