Support typed path parameters in route paths#2912
Open
Harshal96 wants to merge 4 commits into
Open
Conversation
davsclaus
approved these changes
Jun 10, 2026
vietj
reviewed
Jun 10, 2026
vietj
reviewed
Jun 10, 2026
Contributor
|
@Harshal96 we need a test that uses an invalid type, e.g. |
Author
|
@vietj have accommodated the feedback |
vietj
reviewed
Jun 11, 2026
vietj
reviewed
Jun 11, 2026
vietj
reviewed
Jun 11, 2026
Author
|
@vietj good for another review? |
vietj
requested changes
Jun 30, 2026
vietj
left a comment
Contributor
There was a problem hiding this comment.
after looking at this again, the syntax to declare a type is ambiguous with a second parameter.
we can follow the same syntax as SQL query with :: instead of :.
so example should be
router.route("/blah/:id::integer").handler(rc -> rc.response().setStatusMessage(rc.pathParam("id")).end());
Author
|
@vietj updated : -> :: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Closes #2860
This PR adds the syntax proposed in the issue: