-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTTPAPI handlers to return non-200 status codes when errors occur (SYN-8734) #4169
Conversation
…status codes when errors happen
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
- Coverage 97.35% 97.29% -0.07%
==========================================
Files 261 261
Lines 59877 59894 +17
==========================================
- Hits 58294 58273 -21
- Misses 1583 1621 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lt codes for several error cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the requested changes are integers to http.HTTPStatus.XXX
codes.
Co-authored-by: blackout <[email protected]>
Co-authored-by: blackout <[email protected]>
Co-authored-by: Cisphyx <[email protected]>
Co-authored-by: Cisphyx <[email protected]>
…SuchView with their own codes Update the loginV1 handler to sent 403/404 codes on errors.
http.HTTPStatus
enum