Enh: More targeted drive prop set #4211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuy0
commented
Mar 28, 2025
| @@ -69,6 +69,9 @@ def _reqInfoType(self, info, typename): | |||
|
|
|||
| def getItemInfo(self, iden, typename=None): | |||
| info = self._getItemInfo(s_common.uhex(iden)) | |||
| if not info: | |||
There was a problem hiding this comment.
if you supply a typename and the drive doesn't have that iden, you get an unhandled python Attribute error about NoneType not having a get attribute (instead of this method just returning None like it does when the iden doesn't map to any data)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4211 +/- ##
===============================================
- Coverage 96.58% 96.46% -0.12%
===============================================
Files 247 247
Lines 58291 58329 +38
===============================================
- Hits 56299 56269 -30
- Misses 1992 2060 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rakuy0
changed the title
invisig0th
approved these changes
Apr 2, 2025
invisig0th
approved these changes
May 1, 2025
rakuy0
added a commit
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pared down some other perms related things since those belonged more in optic land. I guess the main question is how many rails should we have on the prop path set?