Enh: More targeted drive prop set #4211
Conversation
| @@ -69,6 +69,9 @@ def _reqInfoType(self, info, typename): | |||
|
|
|||
| def getItemInfo(self, iden, typename=None): | |||
| info = self._getItemInfo(s_common.uhex(iden)) | |||
| if not info: | |||
There was a problem hiding this comment.
if you supply a typename and the drive doesn't have that iden, you get an unhandled python Attribute error about NoneType not having a get attribute (instead of this method just returning None like it does when the iden doesn't map to any data)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4211 +/- ##
============================================
Coverage 96.38% 96.38%
============================================
Files 247 247
Lines 57824 57845 +21
============================================
+ Hits 55732 55755 +23
+ Misses 2092 2090 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rakuy0
changed the title
synapse/lib/cell.py
Outdated
| @@ -1715,6 +1715,27 @@ async def delDriveInfo(self, iden): | |||
| async def setDriveInfoPerm(self, iden, perm): | |||
| return self.drive.setItemPerm(iden, perm) | |||
|
|
|||
| @s_nexus.Pusher.onPushAuto('drive:data:path:set') | |||
| async def setDriveItemProp(self, iden, path, valu): | |||
There was a problem hiding this comment.
would we want the ability to update the version with this call?
There was a problem hiding this comment.
I'd say yea. Otherwise you have to do another kinda awkward call to setItemData since there's not really a way to set just the version info. I'll add that param 👍
Pared down some other perms related things since those belonged more in optic land. I guess the main question is how many rails should we have on the prop path set?