-
Notifications
You must be signed in to change notification settings - Fork 81
Enh: More targeted drive prop set #4211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -69,6 +69,9 @@ def _reqInfoType(self, info, typename): | |||
|
|||
def getItemInfo(self, iden, typename=None): | |||
info = self._getItemInfo(s_common.uhex(iden)) | |||
if not info: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you supply a typename and the drive doesn't have that iden, you get an unhandled python Attribute error about NoneType not having a get
attribute (instead of this method just returning None like it does when the iden doesn't map to any data)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4211 +/- ##
===============================================
- Coverage 96.58% 96.46% -0.12%
===============================================
Files 247 247
Lines 58291 58329 +38
===============================================
- Hits 56299 56269 -30
- Misses 1992 2060 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pared down some other perms related things since those belonged more in optic land. I guess the main question is how many rails should we have on the prop path set?