Skip to content

fix clippy warnings on assert_eq with boolean - #1487

Open
perlindgren wants to merge 4 commits into
veryl-lang:masterfrom
perlindgren:master
Open

fix clippy warnings on assert_eq with boolean#1487
perlindgren wants to merge 4 commits into
veryl-lang:masterfrom
perlindgren:master

Conversation

@perlindgren

Copy link
Copy Markdown

Fixed warnings like this:

assert_eq!(is_lower_camel_case("abc"), true);

->

assert!(is_lower_camel_case("abc"));

Alternatively a clippy allow could of course be considered.

@dalance

dalance commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

I can merge the first commit dec2a56.
Or do you plan to change this PR to implementation of bit witdh check?

Signed-off-by: Malte Munch <malte.munch@ltu.se>
@perlindgren

Copy link
Copy Markdown
Author

You can merge as is, the width check will come later.

@dalance

dalance commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator

You can merge as is, the width check will come later.

OK. so could you revert other changes except dec2a56 ?
If I merge this PR as is, unexpected println will be merged too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants