fix(simulator): support array literal function arguments - #3131
Merged
dalance merged 3 commits intoAug 3, 2026
Merged
Conversation
tignear
marked this pull request as draft
August 2, 2026 15:03
Contributor
Author
|
I found that malformed array literal arguments bypass the analyzer. This PR avoids the existing panic, but reports only a generic unsupported description error. I’m converting it back to draft while I fix the diagnostics. Sorry I missed this. |
tignear
marked this pull request as ready for review
August 2, 2026 17:01
tignear
force-pushed
the
fix/simulator-array-literal-function-args
branch
from
August 2, 2026 17:02
9876ba5 to
a099902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand array literals using the formal function argument type before converting their elements into simulator expressions. Previously, passing an array literal directly to a function caused the simulator to panic with
unhandled Expression variant.The added tests cover unpacked, packed, single-element, repeated, default-filled, and multidimensional literals, including nested function calls.