fix: make-feed bug with multiple clusters missed comma#37142
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes invalid JSON produced by vespa visit --make-feed when visiting multiple content clusters by ensuring documents are comma-separated across cluster boundaries, and adds a regression test to validate the output parses as a JSON array.
Changes:
- Track whether feed output has started (
feedStarted) to correctly emit commas between documents across multipledumpDocuments()calls. - Adjust make-feed closing bracket formatting to ensure a newline before
]. - Add a unit test that runs
visit --make-feedagainst multiple clusters and asserts the output unmarshals as a JSON array.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
client/go/internal/cli/cmd/visit.go |
Fixes JSON array formatting for --make-feed across multiple clusters by tracking whether a comma is needed between documents. |
client/go/internal/cli/cmd/visit_test.go |
Adds regression test ensuring --make-feed output is valid JSON when multiple clusters are visited. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if vArgs.makeFeed { | ||
| vArgs.writeString("]\n") | ||
| vArgs.writeString("\n]\n") |
Contributor
Author
There was a problem hiding this comment.
This is only relevant for tests that does not exist for visit...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Closes #36946