Package vespa-crypto-cli-standalone as RPM subpackage#37148
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Packages the standalone Vespa crypto CLI as its own RPM subpackage so it can be installed and run without a full Vespa installation, by installing a self-contained fat JAR plus a launcher script that can locate it both in RPM installs and local dev builds.
Changes:
- Update
vespa-crypto-cli-standalone.shto resolve the fat JAR via an override env var and fallback search paths. - Install the
fat-with-providedJAR and standalone launcher viavespaclient-java/CMakeLists.txt. - Add a
vespa-crypto-cli-standaloneRPM subpackage that ships only the launcher and fat JAR and depends on a headless JRE.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vespaclient-java/src/main/sh/vespa-crypto-cli-standalone.sh | Adds a robust JAR discovery chain (env override, installed path, local target/) and improved failure handling. |
| vespaclient-java/CMakeLists.txt | Installs the standalone launcher and the fat-with-provided JAR into the standard install tree. |
| dist/vespa.spec | Introduces an RPM subpackage for the standalone crypto CLI and ensures the launcher is owned by that subpackage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Resolve fat JAR via env var, installed lib/jars, then target/ - Enables RPM installation while preserving local dev usage
- Install fat JAR + standalone script via CMake - Add vespa-crypto-cli-standalone subpackage; no Vespa dep, JRE only - Allows running the crypto CLI without a Vespa install
gjoranv
force-pushed
the
gjoranv/crypto-cli-standalone-jar-path
branch
from
dedfc29 to
e946abb
Compare
bjorncs
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the standalone crypto CLI installable as an RPM so it can run without a full Vespa installation.
vespa-crypto-cli-standalone.sh: resolve the fat JAR via a fallback chain ($VESPA_CRYPTO_CLI_JAR, then the installedlib/jars/location relative to the script, thentarget/for local dev) instead of the hardcodedtarget/path.vespaclient-java/CMakeLists.txt: install thefat-with-providedJAR and the standalone launcher script.dist/vespa.spec: add avespa-crypto-cli-standalonesubpackage containing only the script and the fat JAR, requires only a headless JRE.AI-assisted PR (Claude Opus 4.8) - all changes verified by the author before submission