Fix validation of queries sent via HTTP POST#37213
Merged
Merged
Conversation
hmusum
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When validating whether query-profile-only parameters are used in a query, only the HTTP request parameters are checked. This means that, for a query sent via POST, the parameters are never validated.
The
SearchHandlerclass has arequestMapFromRequestmethod, which parses the data of a HTTP POST request with JSON data. The fields from this data are then merged with the parameters of the HTTP request into a single map and given to aQueryobject. However, this map is only stored implicitly inside of the query and there is no way to access it directly, which then might have led to checking only the HTTP request parameters.This adds a
getRequestMapmethod toQueryto be able to get the parameters that were actually used when creating the query. This is then used in the validation (which actually happens in two places). Also adds unit tests.@hmusum Please review. Is it ok to add the method here and just hand out a(n unmodifiable) map?