Add CreateAndFreezeTimes, used to keep track of when flushes started#37219
Merged
Conversation
arnej27959
previously approved these changes
Jun 16, 2026
arnej27959
approved these changes
Jun 16, 2026
vekterli
reviewed
Jun 17, 2026
| [[nodiscard]] static std::chrono::steady_clock::duration | ||
| make_flush_duration(const std::chrono::steady_clock::time_point& create_time); | ||
| [[nodiscard]] uint64_t create_time() const noexcept { return _create_time; } | ||
| [[nodiscard]] uint64_t freeze_time() const noexcept { return _freeze_time; } |
Member
There was a problem hiding this comment.
I can't help but feel that this would be semantically cleaner if these were exposed (and possibly internally represented) as system_clock::time_point types instead, since they represent single logical points on the timeline. Possibly with an u64 (create|freeze)_time_us convenience accessor if we do a lot of integer shenanigans on these elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and completed.
@vekterli or @arnej27959 : please review