johsol/iterator benchmark range#37220
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the iterator benchmark test harness with a new attribute range-search benchmark case, adds support for building numeric attributes for benchmarks, and records fetch-postings timing as part of benchmark results.
Changes:
- Added
AttributeRangeBlueprintFactory(+RangeConfig) to generate blueprints for attribute range queries. - Added
AttributeContextBuilder::add_numeric()to populate integer attributes from a generator. - Extended benchmark reporting/pond recording with
fetch_postings_time_msand added a newanalyze_attr_rangetest case.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| searchlib/src/tests/queryeval/iterator_benchmark/leaf_blueprint_factory.h | Adds RangeConfig and AttributeRangeBlueprintFactory declarations. |
| searchlib/src/tests/queryeval/iterator_benchmark/leaf_blueprint_factory.cpp | Implements range attribute population and creates a SimpleRangeTerm blueprint. |
| searchlib/src/tests/queryeval/iterator_benchmark/iterator_benchmark_test.cpp | Adds fetch-postings timing, range config fields, and a new ATTR_RANGE benchmark test. |
| searchlib/src/tests/queryeval/iterator_benchmark/blueprint_factory_builder.h | Declares attr_range() factory builder entry point. |
| searchlib/src/tests/queryeval/iterator_benchmark/blueprint_factory_builder.cpp | Implements attr_range() by constructing AttributeRangeBlueprintFactory. |
| searchlib/src/tests/queryeval/iterator_benchmark/attribute_ctx_builder.h | Declares AttributeContextBuilder::add_numeric(). |
| searchlib/src/tests/queryeval/iterator_benchmark/attribute_ctx_builder.cpp | Implements add_numeric() to create and populate an integer attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
havardpe
previously approved these changes
Jun 17, 2026
havardpe
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.