Track create and freeze times for disk indexes.#37228
Merged
arnej27959 merged 2 commits intoJun 18, 2026
Merged
Conversation
vekterli
previously approved these changes
Jun 17, 2026
| } | ||
|
|
||
| void DiskIndex::get_schema_timestamp() { | ||
| auto schema_mod_time = FileKit::getModificationTime(_indexDir + "/schema.txt.orig"); |
Member
There was a problem hiding this comment.
Would be nice with a small comment on why one is preferred over the other
| common::CreateAndFreezeTimes _create_and_freeze_times; | ||
|
|
||
| void calculate_nonfield_size_on_disk(); | ||
| void get_schema_timestamp(); |
Member
There was a problem hiding this comment.
Consider calling this something else than get_ since it updates internal state, but at first glance looks like a slightly peculiar void-typed accessor. Perhaps "update", "assign" or "calculate" (re: the method above)?
vekterli
approved these changes
Jun 17, 2026
arnej27959
deleted the
toregge/track-create-and-freeze-time-for-disk-indexes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vekterli or @arnej27959 : please review