Consolidate Kotlin dependencies to a single managed version#37238
Merged
Conversation
Adding openai-java pulled in jackson-module-kotlin, which depends on kotlin-reflect 2.1.21, so the build ended up with several Kotlin versions (1.8.0, 1.9.25 and 2.1.21) on the dependency tree and in the enforcer allowlist. Bump kotlin.vespa.version to 2.1.21 so all Kotlin artifacts are managed at one version. The exception is kotlin-stdlib-common, which is not published for major version 2, so keep it at 1.9.25 via a separate kotlin-stdlib-common.vespa.version property. Also add dependency management for the openai-java transitive Kotlin artifacts in hosted-tenant-base, and prune the now-redundant Kotlin version entries from the dependency enforcer allowlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding openai-java pulled in jackson-module-kotlin, which depends on kotlin-reflect 2.1.21, so the build ended up with several Kotlin versions (1.8.0, 1.9.25 and 2.1.21) on the dependency tree and in the enforcer allowlist.
Bump kotlin.vespa.version to 2.1.21 so all Kotlin artifacts are managed at one version. The exception is kotlin-stdlib-common, which is not published for major version 2, so keep it at 1.9.25 via a separate kotlin-stdlib-common.vespa.version property.
Also add dependency management for the openai-java transitive Kotlin artifacts in hosted-tenant-base, and prune the now-redundant Kotlin version entries from the dependency enforcer allowlist.